[ALSA] opl3 - simplify exclusive access lock

Previous thread: [ALSA] Dreamcast AICA sound - Get rid of annoying compiler warning by Linux Kernel Mailing List on Thursday, January 31, 2008 - 4:59 pm. (1 message)

Next thread: [ALSA] ac97_patch: compilation warning fix by Linux Kernel Mailing List on Thursday, January 31, 2008 - 4:59 pm. (1 message)
From: Linux Kernel Mailing List
Date: Thursday, January 31, 2008 - 4:59 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=05c1af...
Commit:     05c1afe75fcebf456017ec186811cf1599f4360e
Parent:     224a033252bba46c5c8b5df625f5e781ca138f48
Author:     Takashi Iwai <tiwai@suse.de>
AuthorDate: Tue Oct 30 11:59:15 2007 +0100
Committer:  Jaroslav Kysela <perex@perex.cz>
CommitDate: Thu Jan 31 17:29:13 2008 +0100

    [ALSA] opl3 - simplify exclusive access lock
    
    Use the exclusive access lock in hwdep instead of the own one.
    
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Jaroslav Kysela <perex@perex.cz>
---
 include/sound/opl3.h            |    2 --
 sound/drivers/opl3/opl3_lib.c   |    2 +-
 sound/drivers/opl3/opl3_seq.c   |   19 +++++++++++--------
 sound/drivers/opl3/opl3_synth.c |   14 --------------
 4 files changed, 12 insertions(+), 25 deletions(-)

diff --git a/include/sound/opl3.h b/include/sound/opl3.h
index 7ee865d..eea584b 100644
--- a/include/sound/opl3.h
+++ b/include/sound/opl3.h
@@ -320,7 +320,6 @@ struct snd_opl3 {
 
 	spinlock_t reg_lock;
 	struct snd_card *card;		/* The card that this belongs to */
-	int used;			/* usage flag - exclusive */
 	unsigned char fm_mode;		/* OPL mode, see SNDRV_DM_FM_MODE_XXX */
 	unsigned char rhythm;		/* percussion mode flag */
 	unsigned char max_voices;	/* max number of voices */
@@ -353,7 +352,6 @@ struct snd_opl3 {
 	int sys_timer_status;		/* system timer run status */
 	spinlock_t sys_timer_lock;	/* Lock for system timer access */
 #endif
-	struct mutex access_mutex;	/* locking */
 };
 
 /* opl3.c */
diff --git a/sound/drivers/opl3/opl3_lib.c b/sound/drivers/opl3/opl3_lib.c
index a657da9..a127084 100644
--- a/sound/drivers/opl3/opl3_lib.c
+++ b/sound/drivers/opl3/opl3_lib.c
@@ -361,7 +361,6 @@ int snd_opl3_new(struct snd_card *card,
 	opl3->hardware = hardware;
 	spin_lock_init(&opl3->reg_lock);
 	spin_lock_init(&opl3->timer_lock);
-	mutex_init(&opl3->access_mutex);
 
 	if ((err ...
Previous thread: [ALSA] Dreamcast AICA sound - Get rid of annoying compiler warning by Linux Kernel Mailing List on Thursday, January 31, 2008 - 4:59 pm. (1 message)

Next thread: [ALSA] ac97_patch: compilation warning fix by Linux Kernel Mailing List on Thursday, January 31, 2008 - 4:59 pm. (1 message)