Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=c...

Commit:     ed086314f4e41eb90a9107c7fb2737230686f668

Parent:     72e04f720f23cfa8d4400d832784f3a424379227

Author:     Mauro Carvalho Chehab <mchehab@infradead.org>

AuthorDate: Thu Jan 24 06:59:20 2008 -0300

Committer:  Mauro Carvalho Chehab <mchehab@infradead.org>

CommitDate: Fri Jan 25 19:05:12 2008 -0200
    V4L/DVB (7060): em28xx: remove has_tuner
    has_tuner flag doesn't make much sense, since tuner_type=TUNER_ABSENT

    means the same thing.
    Having two ways to say that a tuner is not present is

    not nice, since it may lead to bad setups. In fact, with the previous

    code, if a device were using has_tuner=0, but the user forces a tuner,

    with modprobe option tuner=type, the modprobe option won't work.
    Also, tveeprom returns TUNER_ABSENT, when tuner is unknown or absent.

    So, with the previous logic, in this case, the driver should set

    has_tuner=0, or has_tuner=1 otherwise.
    Instead of adding several additional tests and setups, better just to

    remove .has_tuner.
    Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>

---

 drivers/media/video/em28xx/em28xx-cards.c |   29 +++++++----------------------

 drivers/media/video/em28xx/em28xx-video.c |    5 +++--

 drivers/media/video/em28xx/em28xx.h       |    2 --

 3 files changed, 10 insertions(+), 26 deletions(-)
diff --git a/drivers/media/video/em28xx/em28xx-cards.c b/drivers/media/video/em28xx/em28xx-cards.c

index 368a766..2159d01 100644

--- a/drivers/media/video/em28xx/em28xx-cards.c

+++ b/drivers/media/video/em28xx/em28xx-cards.c

@@ -78,7 +78,6 @@ struct em28xx_board em28xx_boards[] = {

 		.is_em2800    = 1,

 		.vchannels    = 2,

 		.tda9887_conf = TDA9887_PRESENT,

-		.has_tuner    = 1,

 		.decoder      = EM28XX_SAA7113,

 		.input           = { {

 			.type     = EM28XX_VMUX_COMPOSITE1,

@@ -93,13 +92,14 @...
[ message continues ]