Home » Mailing list archives » git-commits-head » 2008 » January » 24

sis190: mdio operation failure is not correctly detected

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Linux Kernel Mailing List <linux-kernel@...>
To: <git-commits-head@...>
Subject: sis190: mdio operation failure is not correctly detected
Date: Wednesday, January 23, 2008 - 10:59 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7bf3f2...
Commit:     7bf3f232f7c78efee8c4d14ad9af8a5a40304916
Parent:     11913d30b9fb985b12835037281ae0483be59623
Author:     Francois Romieu <romieu@fr.zoreil.com>
AuthorDate: Sat Nov 17 16:56:43 2007 +0100
Committer:  David S. Miller <davem@davemloft.net>
CommitDate: Wed Jan 23 03:11:45 2008 -0800

    sis190: mdio operation failure is not correctly detected
    
    i ranges from 0 to 100 in the 'for' loop a few lines above.
    
    Reported by davem.
    
    Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
    Cc: K.M. Liu <kmliu@sis.com.tw>
---
 drivers/net/sis190.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c
index 92e0eb9..342a986 100644
--- a/drivers/net/sis190.c
+++ b/drivers/net/sis190.c
@@ -372,7 +372,7 @@ static void __mdio_cmd(void __iomem *ioaddr, u32 ctl)
 		msleep(1);
 	}
 
-	if (i > 999)
+	if (i > 99)
 		printk(KERN_ERR PFX "PHY command failed !\n");
 }
 
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
sis190: mdio operation failure is not correctly detected, Linux Kernel Mailing List..., (Wed Jan 23, 10:59 pm)