e100: cleanup unneeded math

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Friday, December 7, 2007 - 2:59 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=abf9b9...
Commit:     abf9b902059fb1d569b64e8645a76f0fccbdbbe5
Parent:     c32bc6e9b0778c891f7f3b97cd05c8cdf98b6721
Author:     Auke Kok <auke-jan.h.kok@intel.com>
AuthorDate: Wed Dec 5 11:57:37 2007 -0800
Committer:  Jeff Garzik <jeff@garzik.org>
CommitDate: Fri Dec 7 15:01:44 2007 -0500

    e100: cleanup unneeded math
    
    No need to convert to bytes and back - cleanup unneeded code.
    
    Adapted from fix from 'Roel Kluin <12o3l@tiscali.nl>'
    
    Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
    Signed-off-by: Jeff Garzik <jeff@garzik.org>
---
 drivers/net/e100.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/e100.c b/drivers/net/e100.c
index 3dbaec6..e1c8a0d 100644
--- a/drivers/net/e100.c
+++ b/drivers/net/e100.c
@@ -2214,13 +2214,11 @@ static void e100_get_drvinfo(struct net_device *netdev,
 	strcpy(info->bus_info, pci_name(nic->pdev));
 }
 
+#define E100_PHY_REGS 0x1C
 static int e100_get_regs_len(struct net_device *netdev)
 {
 	struct nic *nic = netdev_priv(netdev);
-#define E100_PHY_REGS		0x1C
-#define E100_REGS_LEN		1 + E100_PHY_REGS + \
-	sizeof(nic->mem->dump_buf) / sizeof(u32)
-	return E100_REGS_LEN * sizeof(u32);
+	return 1 + E100_PHY_REGS + sizeof(nic->mem->dump_buf);
 }
 
 static void e100_get_regs(struct net_device *netdev,
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
e100: cleanup unneeded math, Linux Kernel Mailing ..., (Fri Dec 7, 2:59 pm)