login
Header Space

 
 

[PARISC] lba_pci: pci_claim_resources disabled expansion roms

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <git-commits-head@...>
Date: Thursday, December 6, 2007 - 6:59 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=84f450...
Commit:     84f4506cb788d85a50c97b399f2999f90e6272b0
Parent:     721fdf34167580ff98263c74cead8871d76936e6
Author:     Kyle McMartin <kyle@shortfin.cabal.ca>
AuthorDate: Thu Dec 6 09:38:26 2007 -0800
Committer:  Kyle McMartin <kyle@shortfin.cabal.ca>
CommitDate: Thu Dec 6 09:38:26 2007 -0800

    [PARISC] lba_pci: pci_claim_resources disabled expansion roms
    
    radeonfb was HPMC-ing my C8000 by trying to map its expansion rom from
    IO_VIEW, instead of PA_VIEW. Fix seems to be to ensure that its disabled
    ROM is properly inserted into the resource tree.
    
    FIXME: this will result in a whinging printk for cards which share expansion
    ROMS, such as a quad tulip. Thankfully, it isn't harmful.
    
    Signed-off-by: Kyle McMartin <kyle@mcmartin.ca>
---
 drivers/parisc/lba_pci.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/parisc/lba_pci.c b/drivers/parisc/lba_pci.c
index 5eace9e..66ce610 100644
--- a/drivers/parisc/lba_pci.c
+++ b/drivers/parisc/lba_pci.c
@@ -768,9 +768,13 @@ lba_fixup_bus(struct pci_bus *bus)
 				DBG("lba_fixup_bus() WTF? 0x%lx [%lx/%lx] XXX",
 					res->flags, res->start, res->end);
 			}
-			if ((i != PCI_ROM_RESOURCE) ||
-			    (res->flags & IORESOURCE_ROM_ENABLE))
-				pci_claim_resource(dev, i);
+
+			/*
+			** FIXME: this will result in whinging for devices
+			** that share expansion ROMs (think quad tulip), but
+			** isn't harmful.
+			*/
+			pci_claim_resource(dev, i);
 		}
 
 #ifdef FBB_SUPPORT
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PARISC] lba_pci: pci_claim_resources disabled expansion roms, Linux Kernel Mailing List..., (Thu Dec 6, 6:59 pm)
speck-geostationary