Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=505a41...
Commit:     505a41d43c24345f3fa77ddab152d1f82dd8264d
Parent:     95a02cfd4d33886c166d4a5f309120f8d32ced58
Author:     Julia Lawall <julia@diku.dk>
AuthorDate: Mon Dec 10 17:14:46 2007 -0800
Committer:  David S. Miller <davem@sunset.davemloft.net>
CommitDate: Tue Dec 11 02:45:27 2007 -0800

    [UM]: Fix use of skb after netif_rx
    
    Recently, Wang Chen submitted a patch
    (d30f53aeb31d453a5230f526bea592af07944564) to move a call to netif_rx(skb)
    after a subsequent reference to skb, because netif_rx may call kfree_skb on
    its argument.  The same problem occurs in some other drivers as well.
    
    This was found using the following semantic match.
    (http://www.emn.fr/x-info/coccinelle/)
    
    // <smpl>
    @@
    expression skb, e,e1;
    @@
    
    (
     netif_rx(skb);
    |
     netif_rx_ni(skb);
    )
      ... when != skb = e
    (
      skb = e1
    |
    * skb
    )
    // </smpl>
    
    Signed-off-by: Julia Lawall <julia@diku.dk>
    Signed-off-by: David S. Miller <davem@davemloft.net>
---
 arch/um/drivers/net_kern.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/um/drivers/net_kern.c b/arch/um/drivers/net_kern.c
index 73681f1..3c6c44c 100644
--- a/arch/um/drivers/net_kern.c
+++ b/arch/um/drivers/net_kern.c
@@ -98,10 +98,10 @@ static int uml_net_rx(struct net_device *dev)
 	if (pkt_len > 0) {
 		skb_trim(skb, pkt_len);
 		skb->protocol = (*lp->protocol)(skb);
-		netif_rx(skb);
 
 		lp->stats.rx_bytes += skb->len;
 		lp->stats.rx_packets++;
+		netif_rx(skb);
 		return pkt_len;
 	}
 
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html