On Mon, Nov 29, 2010 at 11:10:22AM -0800, Jack Vogel wrote:

quoted text
> Not sure what code you created this from, but its not the new driver,

Yes, that's for previous version and that's what keeps my production
servers from panicing.

quoted text
> things have been reorganized and I do not believe this issue exists.
> Please test with the latest.

I'd rather not risk. Here is the same check for today's RELENG_8 driver.
Please, please take a look. After several days of nearly gigabit load
it has already happened m_head was NULL here, in previous version.
Can it be possible in current version?
There is still no check before dereferencing.

--- if_em.c.orig	2010-11-30 01:16:17.000000000 +0600
+++ if_em.c	2010-11-30 01:19:09.000000000 +0600
@@ -4321,10 +4321,12 @@
                          
 	/* Reset state, keep loaded DMA map and reuse */
 	m = rbuf->m_head;
+	if(m) {
 	m->m_len = m->m_pkthdr.len = adapter->rx_mbuf_sz;
 	m->m_flags |= M_PKTHDR;
 	m->m_data = m->m_ext.ext_buf;
 	m->m_next = NULL;
+	}
 
 	return;
 }
_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"