Dag-Erling Sm=F8rgrav schrieb am 2009-11-09:

quoted text
> Alexander Best  writes:

> > +     if ((env_speed =3D getenv("BURNCD_SPEED")) !=3D NULL) {

quoted text
> > +             if (strcasecmp("max", env_speed) =3D=3D 0)

> > +                     speed =3D CDR_MAX_SPEED;

> > +             else

> > +                     speed =3D atoi(env_speed) * 177;

> > +             if (speed <=3D 0)

> > +                     errx(EX_USAGE, "Invalid speed: %s",

> >   env_speed);

> > +     }

> > +

> >       while ((ch =3D getopt(argc, argv, "def:Flmnpqs:tv")) !=3D -1) {

> >               switch (ch) {

> >               case 'd':

> You realize you're duplicating 6 lines of non-trivial code for no

quoted text
> good

> reason?

> env_speed =3D getenv("BURNCD_SPEED");
> while ((ch =3D getopt(...)) !=3D -1) {

quoted text
>     switch (ch) {

>     case 's':

>         env_speed =3D optarg;

>         break;

>     ...

>     }

> }

> if (env_speed !=3D NULL) {

quoted text
>     if (strcasecmp...) {

>         ...

>     }

> }

> DES
good point. is this one better?
alex