Nice pair of features :-)
If there are no pressing space constraints maybe we can build both
options in by default, but still make them opt-out when necessary?
With a bit of makefile glue we can make it possible to compile with an
`src.conf' that includes:
WITH_CDBOOT_SILENT=1
WITHOUT_CDBOOT_PROMPT=1
This way the defaults can include support for both options, but we can
conditionally compile *out* the bits that are not needed for some custom
installation.
Something like this can define one or both of these options in CFLAGS,
depending on what `src.conf' contains:
# When CDBOOT_SILENT is set, the cdboot doesn't produce any messages except
# "Loading, please wait..." and it also passes RBX_MUTE flag to the next
# stage to silence it as well. This is intended for custom installations
# where end-user is not required to see any messages or interfere with the
# boot process.
.if ${MK_CDBOOT_SILENT} != "no"
CFLAGS+= -DCDBOOT_SILENT
.endif
# When CDBOOT_PROMPT is enabled the cdboot behaves like windows xp or vista
# cd loader, that is it reads MBR from the first hard drive in the system
# and if the MBR is bootable (i.e. drive has some other operating system
# installed on it) then it presents user with "Press any key to boot from
# CD" prompt and waits for 20 seconds. If key is not pressed then the
# control is passed to the MBR, otherwise CD is booted. This is intended for
# installation CD to allow unattended mode and also helps when installation
# CD has been unintentionally left in the drive of the machine that is set
# to boot off CD.
.if ${MK_CDBOOT_PROMPT} != "no"
CFLAGS+= -DCDBOOT_PROMPT
.endif
The defaults for ${MK_CDBOOT_XXX} will have to be explicitly set in
`src/share/mk/bsd.own.mk', near line 281:
281 #
282 # MK_* options which default to "yes".
283 #
284 .for var in \
...
But that shouldn't be a problem, AFAICT ...
