Re: Next ZFSv28 patchset ready for testing.

Previous thread: [head tinderbox] failure on i386/pc98 by FreeBSD Tinderbox on Sunday, December 12, 2010 - 12:25 am. (1 message)

Next thread: Re: a few OptionalObsoleteFiles.inc improvements by b. f. on Monday, December 13, 2010 - 9:47 pm. (11 messages)
From: Pawel Jakub Dawidek
Date: Monday, December 13, 2010 - 2:45 pm

Hi.

The new patchset is ready for testing:

	http://people.freebsd.org/~pjd/patches/zfs_20101212.patch.bz2

When applying the patch be sure to use correct options for patch(1)!:

	# cd /usr/src
	# fetch http://people.freebsd.org/~pjd/patches/zfs_20101212.patch.bz2
	# bzip2 -d zfs_20101212.patch.bz2
	# patch -E -p0 < zfs_20101212.patch

The patch is against FreeBSD HEAD as of 2010-12-12.

Some of the changes since the last patchset (zfs_20100831.patch):

- Boot support for ZFS v28 (only RAIDZ3 is not yet supported).
- Various fixes for the existing ZFS boot code.
- Support for sendfile(2) (by avg@).
- Userland<->kernel compatibility with v13-v15 (by mm@).
- ACL fixes (by trasz@).
- Various bug fixes.

Please test, test, test. Chances are this is the last patchset before
v28 going to HEAD (finally). Especially test new changes, like boot
support and sendfile(2) support. Also be sure to verify if you can
import for existing ZFS pools (v13-v15) when running v28 or boot from
your existing pools.

Enjoy!

PS. Martin (mm@) will be providing patch against 8-STABLE soon.

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
From: Pawel Jakub Dawidek
Date: Monday, December 13, 2010 - 3:45 pm

[...]

If patch(1) reports reject of sys/cddl/compat/opensolaris/sys/sysmacros.h
file or you see the following error while compiling world:

/usr/src/cddl/usr.bin/ctfconvert/../../../cddl/contrib/opensolaris/tools/ctf/cvt/strtab.c:249: undefined reference to `MIN'
strtab.o(.text+0x28d): In function `strtab_insert':
/usr/src/cddl/usr.bin/ctfconvert/../../../cddl/contrib/opensolaris/tools/ctf/cvt/strtab.c:119: undefined reference to `MIN'
strtab.o(.text+0x3a1):/usr/src/cddl/usr.bin/ctfconvert/../../../cddl/contrib/opensolaris/tools/ctf/cvt/strtab.c:145: undefined reference to `MIN'
*** Error code 1

Simple remove sys/cddl/compat/opensolaris/sys/sysmacros.h file from the tree.

Unfortunately the patch can either works on source downloaded via cvsup or on
the source downloaded via subversion as those two have different $FreeBSD$ id
strings (at least in case of this file). The patch is generated based on
subversion source, so if you use cvsup, you most likely will see the reject and
the error.

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
From: Pawel Jakub Dawidek
Date: Monday, December 13, 2010 - 4:12 pm

You can also download the whole source tree already patched from here:

	http://people.freebsd.org/~pjd/zfs_20101212.tbz

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
From: Pawel Jakub Dawidek
Date: Tuesday, January 4, 2011 - 12:46 pm

Could you verify if this patch fixes the problem for you?

	http://people.freebsd.org/~pjd/patches/vdev_file.c.2.patch

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
From: Pawel Jakub Dawidek
Date: Tuesday, December 14, 2010 - 12:03 am

No. The patch doesn't address that. It only adds support for

The code is correct. It is just hard to split 'else' and 'if' with a
'#endif' and keep the indentation pretty. Depends on the conditions we
use one of the three methods to read the data.

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
From: Olivier Smedts
Date: Tuesday, December 14, 2010 - 6:58 am

I tried it on my 8-STABLE box (root zpool v15 on 2 mirrored vdevs with
an usb l2 cache). I checked-out CURRENT sources with svn, applied the
patch (it applied cleanly). Did not modify kernel config (no
debugging) or make.conf. buildworld, buildkernel, installkernel
INSTKERNNAME=CURRENT and rebooted in single-user mode with
kernel="CURRENT". No problem so far, the kernel displayed the good
freebsd/zpool/zfs version numbers, and it booted correctly in
single-user mode. But I had problems with userland v15 :
# mount
tank/freebsd on / (zfs, local, noatime, read-only)
devfs on /dev (devfs, local)
# zpool status
Assertion failed: (nvlist_lookup_uint64_array(nvroot,
ZPOOL_CONFIG_STATS, (uint64_t **)&vs, &vsc) == 0), file
/usr/src/cddl/lib/libzfs/../../../cddl/contrib/opensolaris/lib/libzfs/common/libzfs_status.c,
line 181.
pid 20 (zpool), uid 0: exited on signal 6
Abort trap


Cheers

-- 
Olivier Smedts                                                 _
                                        ASCII ribbon campaign ( )
e-mail: olivier@gid0.org        - against HTML email & vCards  X
www: http://www.gid0.org    - against proprietary attachments / \

  "Il y a seulement 10 sortes de gens dans le monde :
  ceux qui comprennent le binaire,
  et ceux qui ne le comprennent pas."
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
From: Steven Hartland
Date: Tuesday, December 14, 2010 - 7:05 am

----- Original Message ----- 

build and install world?
cd /usr/src
make buildworld
make installworld

    Regards
    Steve

================================================
This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it. 

In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337
or return the E.mail to postmaster@multiplay.co.uk.

_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
From: Olivier Smedts
Date: Tuesday, December 14, 2010 - 7:20 am

That's what I wanted to do, and why I rebooted single-user on the new
kernel. But isn't the v13-v15 userland supposed to work with the v28


-- 
Olivier Smedts                                                 _
                                        ASCII ribbon campaign ( )
e-mail: olivier@gid0.org        - against HTML email & vCards  X
www: http://www.gid0.org    - against proprietary attachments / \

  "Il y a seulement 10 sortes de gens dans le monde :
  ceux qui comprennent le binaire,
  et ceux qui ne le comprennent pas."
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
From: Pawel Jakub Dawidek
Date: Tuesday, December 14, 2010 - 8:44 am

Yes, it is suppose to work. Exactly to be able to follow FreeBSD common
upgrade path. Martin was working on this (CCed).

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
From: Olivier Smedts
Date: Tuesday, December 14, 2010 - 9:53 am

Ok, glad to hear that.

FYI, with the patched 9-CURRENT kernel in single user mode and the
8-STABLE world, I could "zfs list", "zfs list -t snapshot", "zfs mount
-a" and "zfs unmount -a" ; those zfs commands worked properly. I only
had problems with the zpool command (see previous mails for the error
message). It was not necessary for the upgrade path, and I was able to
make installworld, but I first wanted to see if the pool reported
problems.

With the 9-CURRENT world, all is working properly since 2 hours.
Desktop/workstation use on an Intel 8-core (4 real with HTT), 4GB RAM,
ATI RadeonHD. KDE with compositing, firefox and thunderbird are
running fine. No ZFS debug messages except mount_snapshot. I left the
few 8-STABLE old libraries, and did not upgrade the pool or the
filesystems. Don't want to try that on a "production" desktop machine
until it's safer :)

Cheers

-- 
Olivier Smedts                                                 _
                                        ASCII ribbon campaign ( )
e-mail: olivier@gid0.org        - against HTML email & vCards  X
www: http://www.gid0.org    - against proprietary attachments / \

  "Il y a seulement 10 sortes de gens dans le monde :
  ceux qui comprennent le binaire,
  et ceux qui ne le comprennent pas."
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
From: Martin Matuska
Date: Tuesday, December 14, 2010 - 3:29 pm

Thanks for the notice.

I have found the cause of this error (wrong constants), tested the code
in both directions again (v15->v28 and v28->v15) + fixed it in perforce.

Bugfix patch (apply after pjd's patch):
http://people.freebsd.org/~mm/patches/zfs/v28/head-zfs_ioctl_compat.c.patch

_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
From: Chris Forgeron
Date: Wednesday, December 15, 2010 - 1:40 pm

I've installed and complied it on 9-Current 2010.12.12, looks to be running fine.

I've imported a v15 6 disk raidz that was created under 8.1-Stable, and so far it's passing all tests.

I'll be doing some serious Send/Receive testing in the next few days, so I'll see if I can break it. 

I'll also be upgrading the v15 fs to v28 and testing it further, as well as creating a fresh v28 pool, so I'll let you know how it goes. 


-----Original Message-----
From: owner-freebsd-current@freebsd.org [mailto:owner-freebsd-current@freebsd.org] On Behalf Of Pawel Jakub Dawidek
Sent: December-14-10 11:44 AM
To: Olivier Smedts
Cc: freebsd-fs@freebsd.org; freebsd-current@freebsd.org; Steven Hartland; mm@FreeBSD.org
Subject: Re: Next ZFSv28 patchset ready for testing.


Yes, it is suppose to work. Exactly to be able to follow FreeBSD common upgrade path. Martin was working on this (CCed).

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
From: Anonymous
Date: Wednesday, December 15, 2010 - 12:33 pm

$ zfs allow
  Traceback (most recent call last):
  File "/usr/lib/zfs/pyzfs.py", line 35, in <module>
  import zfs.util
  File "/usr/local/lib/python2.7/site-packages/zfs/util.py", line 31, in <module>
  import solaris.misc
  ImportError: No module named solaris.misc
  Exit 1

Am I missing smth? Looks like lib/pysolaris wasn't ported from onnv-gate.
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
From: Anonymous
Date: Wednesday, December 15, 2010 - 12:42 pm

Doh, it's likely my install is broken, I think it worked before with
previous ZFSv28 patch.
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
From: Anonymous
Date: Wednesday, December 15, 2010 - 11:47 pm

A bit more noise from me using v28 pool

- pyzfs from v15 segfaults
- pyzfs from v28 fails on solaris.misc
 \- removing solaris.misc refs makes it fail on set_fsacl ioctl[1]
- but it works on C version from illumos[2]

[1] $ zfs allow myuser create foo/bar
    cannot set permissions on foo/bar: Invalid argument
    WARNING pid 52434 (initial thread): ioctl sign-extension ioctl ffffffffd5985a12

[2] attached in case anyone depends on `zfs allow' like me
From: ben wilber
Date: Wednesday, December 15, 2010 - 8:15 pm

Running fine for 24 hours now under load with a ~50 disk v15 (not
upgraded) pool from -CURRENT.  Thanks!

Only strange thing is the rc script complains:

/etc/rc: DEBUG: run_rc_command: doit: zvol_start 
unrecognized command 'volinit'
usage: zfs command args ...

_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
From: Pawel Jakub Dawidek
Date: Thursday, December 16, 2010 - 12:19 am

Did you run mergemaster(8) after the upgrade? The patch includes change
to etc/rc.d/zvol to remove 'zfs volinit'/'zfs volfini' which are no
longer available.

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
From: Doug Barton
Date: Friday, December 17, 2010 - 4:47 pm

By default mergemaster will only notice the change if the $FreeBSD id 
changes, which it generally would not for a patch. The -s option will 
deal with this, but it may be less work to just cp the file.


Doug

-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/

_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
From: Alexander V. Ribchansky
Date: Thursday, December 16, 2010 - 9:04 am

First of all, thank pjd@, mm@ and others who made zfs go ahead in 
FreeBSD! You are absolutely monsters!

Now one question, what I do wrong, that I can't use /boot/zfsboot to 
boot MBR+zfs-only FreeBSD?
More info. If I use /boot/zfsboot form recent STABLE (from snapshot CD 
or built myself) to boot up this

monstro# gpart show ad6
=>       63  625142385  ad6  MBR  (298G)
          63  104872257    1  ntfs  [active]  (50G)
   104872320  520270128    2  freebsd  (248G)

monstro# gpart show ad6s2
=>        0  520270128  ad6s2  BSD  (248G)
           0  516075824      1  freebsd-zfs  (246G)
   516075824    4194304      2  freebsd-swap  (2.0G)

I install /boot/zfsboot as

dd if=/boot/zfsboot of=/dev/ad6s2 count=1
dd if=/boot/zfsboot of=/dev/ad6s2a skip=1 seek=1024

when I reboot, system stuck in "-" or "\" or "/" or finaly "|" prompt.

when I install /boot/zfsboot from recent 9-CURRENT snapshot CD all 
boots-up perfectly.
More over, fresh built /boot/zfsboot from v28 pachset either from 8-S or 
9-C patches stuck as I describe above.

What I miss? Can somebody send me known to work copy of /boot/zfsboot 
from v28 patchset?

Thanks!

--
     WBR,
     Alexander V. Ribchansky
     AVR39-RIPE

_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
From: Olivier Smedts
Date: Thursday, December 16, 2010 - 12:45 pm

Boot support ok with gptzfsboot and zfsloader on a mirrored v15 root
pool and a single disk v15 root pool.

# zfs diff tank/data@20101204 tank/data@20101208
Cannot stat /data/.zfs/shares/: unable to generate diffs
# ls /data/.zfs/
snapshot/

This pool was created in -STABLE more than a year ago, I think it was
zpool version 13. I upgraded it to version 15, upgraded the
filesystems, but there are no "shares" directories in the .zfs folder
of the filesystems in this pool.

Another pool created few days ago directly in version 15 :
# ls /temp/.zfs/
shares/   snapshot/

I never used shares in any of my pools/filesystems. Should the
".zfs/shares" directories be created automatically ?

Thanks

-- 
Olivier Smedts                                                 _
                                        ASCII ribbon campaign ( )
e-mail: olivier@gid0.org        - against HTML email & vCards  X
www: http://www.gid0.org    - against proprietary attachments / \

  "Il y a seulement 10 sortes de gens dans le monde :
  ceux qui comprennent le binaire,
  et ceux qui ne le comprennent pas."
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
From: Olivier Smedts
Date: Thursday, December 16, 2010 - 12:45 pm

Boot support ok with gptzfsboot and zfsloader on a mirrored v15 root
pool and a single disk v15 root pool.

# zfs diff tank/data@20101204 tank/data@20101208
Cannot stat /data/.zfs/shares/: unable to generate diffs
# ls /data/.zfs/
snapshot/

This pool was created in -STABLE more than a year ago, I think it was
zpool version 13. I upgraded it to version 15, upgraded the
filesystems, but there are no "shares" directories in the .zfs folder
of the filesystems in this pool.

Another pool created few days ago directly in version 15 :
# ls /temp/.zfs/
shares/   snapshot/

I never used shares in any of my pools/filesystems. Should the
".zfs/shares" directories be created automatically ?

Thanks

-- 
Olivier Smedts                                                 _
                                        ASCII ribbon campaign ( )
e-mail: olivier@gid0.org        - against HTML email & vCards  X
www: http://www.gid0.org    - against proprietary attachments / \

  "Il y a seulement 10 sortes de gens dans le monde :
  ceux qui comprennent le binaire,
  et ceux qui ne le comprennent pas."
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
From: Olivier Smedts
Date: Friday, December 17, 2010 - 4:37 pm

When booting my v15 mirrored pool with only one disk available, I've
Dec 18 00:31:55 q kernel: Trying to mount root from zfs:tank/freebsd []...
Dec 18 00:31:55 q kernel: log_sysevent: type 19 is not implemented
Dec 18 00:31:55 q kernel: log_sysevent: type 19 is not implemented


-- 
Olivier Smedts                                                 _
                                        ASCII ribbon campaign ( )
e-mail: olivier@gid0.org        - against HTML email & vCards  X
www: http://www.gid0.org    - against proprietary attachments / \

  "Il y a seulement 10 sortes de gens dans le monde :
  ceux qui comprennent le binaire,
  et ceux qui ne le comprennent pas."
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
From: Anonymous
Date: Sunday, December 19, 2010 - 8:42 pm

`-e' option in zdb(8) now looks under /dev/dsk by default

  $ zdb -ec blah

  Configuration for import:
          vdev_children: 1
          version: 6
          vdev_tree:
              children[0]:
                  phys_path: '/dev/gptid/A-B-C-D-E'
                  path: '/dev/dsk/gptid/A-B-C-D-E'
  zdb: can't open 'blah': No such file or directory
  Exit 1

  $ zdb -p /dev -ec blah

  Traversing all blocks to verify metadata checksums and verify nothing leaked ...
  Assertion failed: (mp->initialized == B_TRUE), file /usr/src/cddl/lib/libzpool/../../../cddl/contrib/opensolaris/lib/libzpool/common/kernel.c, line 130.
  Exit 134
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
Previous thread: [head tinderbox] failure on i386/pc98 by FreeBSD Tinderbox on Sunday, December 12, 2010 - 12:25 am. (1 message)

Next thread: Re: a few OptionalObsoleteFiles.inc improvements by b. f. on Monday, December 13, 2010 - 9:47 pm. (11 messages)