Subject: Re: panic: System call lstat returning with 1 locks held

From: Yar Tikhiy <yar@...> · Date: Thursday, January 31, 2008 - 9:02 am

On Thu, Jan 31, 2008 at 11:43:10AM +0100, Attilio Rao wrote:
quoted text> 
> The assertion failing should not happen now.
> Could you please hand-add a check in _lockmgr_disown()
> (kern/kern_lock.c) in order to check for the panicstr before to call
> WITNESS? I cannot access to perforce now and produce a suitable diff,
> so you can just do this by hand:
> 
> if (lkp->lk_lockholder == td) {
>         if (panicstr != NULL)
>                 WITNESS_UNLOCK(&lkp->lk_object, LOP_EXCLUSIVE, file, line);
>         td->td_locks--;
> }

Shouldn't the test for panicstr be inverse: `panicstr == NULL'?
I guess we shouldn't call WITNESS when panicing, should we?
Sorry if I got it wrong.

-- 
Yar
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"


linux-kernel:
Amit K. Arora	[RFC] Heads up on sys_fallocate()
James Bottomley	Re: Integration of SCST in the mainstream Linux kernel
Stephen Rothwell	Re: Announce: Linux-next (Or Andrew's dream :-))
Greg KH	[GIT PATCH] driver core patches against 2.6.24
git:

linux-netdev:
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Patrick McHardy	Re: [GIT]: Networking
Natalie Protasevich	[BUG] New Kernel Bugs
openbsd-misc: