On Wed, 2008-01-23 at 20:34 +0100, Pawel Worach wrote:
quoted text
> Kostik Belousov wrote:
> > On Tue, Jan 22, 2008 at 07:26:53PM +0100, Pawel Worach wrote:
> >> Kostik Belousov wrote:
> >>> On Sun, Jan 20, 2008 at 04:42:36AM +0100, Pawel Worach wrote:
> >>>> Hi,
> >>>>
> >>>> While starting console-kit-daemon (sysutils/consolekit 0.2.3) during=
=20
quoted text
> >>>> boot or in single-user mode the system panics. If I start it post-bo=
ot=20
quoted text
> >>>> it runs fine. This is on 8.0-CURRENT from about 12 hours ago, anothe=
r=20
quoted text
> >>>> user also reported the same on RELENG_7. Any other information I can=
=20
quoted text
> >>>> provide ?
> >>>>
> >>>> Fatal trap 12: page fault while in kernel mode
> >>>> fault virtual address	=3D 0x4
> >>>> fault code		=3D supervisor read, page not present
> >>>> instruction pointer	=3D 0x20:0xc04d2ab4
> >>>> stack pointer	        =3D 0x28:0xe6499b18
> >>>> frame pointer	        =3D 0x28:0xe6499b80
> >>>> code segment		=3D base 0x0, limit 0xfffff, type 0x1b
> >>>> 			=3D DPL 0, pres 1, def32 1, gran 1
> >>>> processor eflags	=3D interrupt enabled, resume, IOPL =3D 0
> >>>> current process		=3D 134 (console-kit-daemon)
> >>>> Physical memory: 1014 MB
> >>>> Dumping 43 MB: 28 12
> >>>>
> >>>> #8  0xc07a34a2 in trap (frame=3D0xe6499ad8) at=20
> >>>> /usr/src/sys/i386/i386/trap.c:489
> >>>> #9  0xc079183b in calltrap () at /usr/src/sys/i386/i386/exception.s:=
146
quoted text
> >>>> #10 0xc04d2ab4 in scioctl (dev=3D0xc3b20d00, cmd=3D537163270,
> >>>>    data=3D0xe6499c70 "__PLACEHOLDER__5_2", flag=3D1, td=3D0xc3d3c880)
> >>>>    at /usr/src/sys/dev/syscons/syscons.c:1073
> >>>> #11 0xc051ed1a in giant_ioctl (dev=3D0xc3b20d00, cmd=3D537163270,
> >>>>    data=3D0xe6499c70 "__PLACEHOLDER__5_2", fflag=3D1, td=3D0xc3d3c880)
> >>>>    at /usr/src/sys/kern/kern_conf.c:349
> >>>> #12 0xc0598194 in cnioctl (dev=3D0xc3b20d00, cmd=3D537163270,
> >>>>    data=3D0xe6499c70 "__PLACEHOLDER__5_2", flag=3D1, td=3D0xc3d3c880)
> >>>> ---Type <return> to continue, or q <return> to quit---
> >>>>    at /usr/src/sys/kern/tty_cons.c:521
> >>> Unless the virtual screen is opened, the screen state scr_stat struct=
ure
quoted text
> >>> is not allocated. The following patch would fix the panic, but I do n=
ot
quoted text
> >>> know how the console-kit would react to the ENXIO from the
> >>> VT_WAITACTIVE ioctl. Please, test it.
> >> Thanks! The patch works.
> >=20
> > To clarify: do you see any problems with the console-kit after the patc=
h ?
quoted text
> > In particular, can you verify that the program functions correctly, esp=
.
quoted text
> > on the virtual terminals 1, 2 ... , whatever this means ?
>=20
> The panic is of course gone, while chatting a bit with Marcus (CCd) it=20
> looks like console-kit does not do any error handling at all. I've not=20
> looked at what c-k does so maybe Marcus can answer the question better.

It tries to install a wait thread on each available VT.  That thread
sets the WAITACTIVE ioctl, and waits for its VT to become active.  When
it does, it sets the CK active VT accordingly, and reattaches the wait.

When an error occurs in the ioctl, no wait is attached, and CK will not
know when a particular VT becomes active.  This will essentially cripple
CK (assuming the VT really does become available at a later point). =20

Now, admittedly, there is no error correction in CK for this situation.
It would be trivial to add something that periodically attempts to
reestablish a failed wait.  However, I am very curious why only a few
users are seeing this panic (me excluded on two different machines).  It
seems to me that the scp should be initialized when sc_attach_unit() is
called during device probing.  I don't see anything special in init(8)'s
code that would cause these VT devices to become initialized.  I would
assume that if one can open(2) them, then they should be available for
ioctls?

Joe

--=20
Joe Marcus Clarke
FreeBSD GNOME Team      ::      gnome@FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome