Re: Unionfs patchset p19 commit?

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Kurt Jaeger <lists@...>, <emaste@...>
Cc: <freebsd-current@...>, <freebsd-stable@...>
Date: Thursday, September 20, 2007 - 2:32 am

Kurt Jaeger wrote:

It looks like interesting. But your patch has a issues.

  +		/* fprintf(stderr,"found upper vnode\n"); */
  +		res = ufs_filestat(&upper, fsp);

and

  +		/* fprintf(stderr,"found lower vnode\n"); */
  +		res = ufs_filestat(&lower, fsp);

depend on UFS. It must treat both UFS and no UFS fs.

And I am not a maintainer of fstat(1). Please contact to
maintainer. Perhaps Ed Maste(emaste) is maintainer I suppose
from commit log.


The isunionfs.c looks like interesting, too :) But your
program is not complete. 'below' option gives it non-correct
work. Addition it does not consider unionfs and nullfs
combibation or something like that. To check upper/lower
completely, you need the same way of your fstat(1) patch.

But your idea looks interesting :)  Keep your concern of
unionfs. To get keep concern is very good for us!

-- 
   Daichi GOTO, http://people.freebsd.org/~daichi
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: Unionfs patchset p19 commit?, Daichi GOTO, (Tue Sep 18, 1:35 am)
Re: Unionfs patchset p19 commit?, Kurt Jaeger, (Tue Sep 18, 10:16 pm)
Re: Unionfs patchset p19 commit?, Daichi GOTO, (Thu Sep 20, 2:32 am)
Re: Unionfs patchset p19 commit?, Ivan Voras, (Wed Sep 19, 5:32 am)
Re: Unionfs patchset p19 commit?, Ivan Voras, (Wed Sep 19, 5:34 am)