login
Header Space

 
 

bin/123703: qualify bad diagnostic in src/usr.sbin/timed/timedc/cmds.c

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <FreeBSD-gnats-submit@...>
Date: Thursday, May 15, 2008 - 9:42 am

>Number:         123703
http://berklix.com BSD Linux Unix Consultancy, Munich/Muenchen.
System: FreeBSD fire.js.berklix.net 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Mon Sep 17 23:01:21 CEST 2007 jhs@fire.js.berklix.net:/usr1/src/sys/amd64/compile/FIRE64.small amd64


	
	qualify bad diagnostic in src/usr.sbin/timed/timedc/cmds.c
	get remote host as timed master,
	localhost as timed slave,
	then kill remote
	& see local lieing.

	
Copy appended of 
http://berklix.com/~jhs/src/bsd/fixes/freebsd/src/gen/usr.sbin/timed/timed/cmds.c.diff...

Before this patch if the remote master was killed, the local slave lied & said
	communication error with localhost
With this patch the code at least no longer lies.

Patch is hack, 
I would like to read the code & do better, but I dont have time.

the code has not been unchanged for over 4 years 
this diff also applies to 7.0-RELEASE

*** 6.2-RELEASE/src/usr.sbin/timed/timedc/cmds.c	Wed Feb  4 22:59:29 2004
--- new-generic/src/usr.sbin/timed/timedc/cmds.c	Thu May 15 15:20:19 2008
***************
*** 356,361 ****
--- 356,364 ----
  			}
  		} else {
  			printf("communication error with %s\n", tgtname);
+ 			printf(
+ " (A dead remote master is also reported as \"... with localhost\").\n"
+ 				);
  		}
  	} while (++i < argc);
  }


_______________________________________________
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscribe@freebsd.org"
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
bin/123703: qualify bad diagnostic in src/usr.sbin/timed/tim..., "Julian H. Stacey" <jhs@berklix.com>..., (Thu May 15, 9:42 am)
speck-geostationary