Re: 0 bytes sized file can't be written to a HAMMER partition

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <kernel@...>
Date: Tuesday, June 10, 2008 - 2:20 pm

:> It looks like the code should be changed to:
:> 
:> if (uio->uio_offset < 0 || uio->uio_offset + uio->uio_resid < 0) {
:>        hammer_done_transaction(&trans);
:>        return (EFBIG);
:> }
:
:Applying that change the issue I'm able to copy zero-bytes sized files 
:to a HAMMER partition:
:
:master# touch /tmp/qq && cp /tmp/qq /datapool/
:master# ls -l /datapool/qq
:-rw-r--r--  1 root  wheel  0 Jun 10 19:43 /datapool/qq
:master# mount |grep datapool
:datapool on /datapool (hammer, local)
:
:Thank you
:Antonio Huete

    I'll commit the fix.  It needs one slight modification though because
    changing that '<=' to '<' allows a wrap case to get past when
    uio_resid != 0.

						-Matt
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: 0 bytes sized file can't be written to a HAMMER partition, Matthew Dillon, (Tue Jun 10, 2:20 pm)
RE: 0 bytes sized file can't be written to a HAMMER partition, Jonathan Stuart, (Wed Jun 11, 12:49 am)