login
Header Space

 
 

Re: dcons_crom and bus_generic_identify_sameunit()

Previous thread: ACPI / SATA / FFS - truncated directories, etc. by Chris Turner on Friday, October 26, 2007 - 7:31 pm. (1 message)

Next thread: Re: progress report -> nata + APIC = no disks found by Matthew Dillon on Friday, October 26, 2007 - 11:53 pm. (1 message)
To: <kernel@...>
Date: Friday, October 26, 2007 - 11:51 pm

Hmm.   dcons doesn't get a lot of use, I'm not surprised that it's
    semi-broken.  What exactly isn't working?  Is it not attaching it
    properly?

					-Matt
					Matthew Dillon 
					&lt;dillon@backplane.com&gt;
To: <kernel@...>
Date: Sunday, October 28, 2007 - 11:57 am

Well, when bus_generic_identify_sameunit() returns zero without calling 
BUS_ADD_CHILD() first, the dcons_crom_{probe,attach} methods don't get 
called. Unless I'm completely misreading the code DS_ATTACHED shouldn't be 
set. BTW, naming the device_t parameter in bus_generic_identify*() 
as "parent" is confusing because AFAICT this is the actual device, not any 
ancestor.

If the bug isn't obvious don't waste any time on it, I want to read some of 
the bus/device code anyway, so I'll investigate some more. Just give me a 
couple of weeks to finish with my exams and rest a bit first...

Aggelos
Previous thread: ACPI / SATA / FFS - truncated directories, etc. by Chris Turner on Friday, October 26, 2007 - 7:31 pm. (1 message)

Next thread: Re: progress report -> nata + APIC = no disks found by Matthew Dillon on Friday, October 26, 2007 - 11:53 pm. (1 message)
speck-geostationary