"Looking at the code it's apparently because I'm not an optimistic enough dad. But hey, if you had three pre-teenage girls, you might not be all that optimistic either."
What is that, a base64-encoded commit or something? Indeed, it is, as running it through "base64 -d" yields:
From: Linus Torvalds
Date: Sun, 20 Jul 2008 18:07:28 -0700 (PDT)
> This warning also seems to be new:
>
> net/ipv6/addrconf.c: In function ¡addrconf_add_linklocal¢:
> net/ipv6/addrconf.c:2318: warning: unused variable ¡net¢
>
> and looking at the code it's apparently because I'm not an optimistic
> enough dad.
>
> But hey, if you had three pre-teenage girls, you might not be all that
> optimistic either. So I think that's reasonable.
>
> Problem seems to have been introduced by 53b7997f ("ipv6 netns: Make
> several "global" sysctl variables namespace aware")
Let's just expand the thing in the one spot it gets
referenced in.
Please apply, thanks.
ipv6: Fix warning in addrconf code.
Reported by Linus.
Signed-off-by: David S. Miller
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 580ae50..9f4fcce 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2315,12 +2315,11 @@ static void init_loopback(struct net_device *dev)
static void addrconf_add_linklocal(struct inet6_dev *idev, struct in6_addr *addr)
{
struct inet6_ifaddr * ifp;
- struct net *net = dev_net(idev->dev);
u32 addr_flags = IFA_F_PERMANENT;
#ifdef CONFIG_IPV6_OPTIMISTIC_DAD
if (idev->cnf.optimistic_dad &&
-
I hear you . . . as I have two teenage girls and one 22 year old son who is back living at home. It is not necessarily the kids that are always the challenge, but being in unity with the wife takes more energy than working with the kids.
I think I need a rest . . . maybe in 5 or 6 years.
Pre-teenage girls
Oh, you think having three pre-teenage girls is difficult?
Wait until they are teenage girls...
Maybe that's has point about
Maybe that's has point about optimism; "In two years... Hell WILL break loose" ;)
Teenage Daughters...
There's an old saying in my family that teenage daughters are God's way of punishing men for having been teenage boys.
*chuckle*
David Miller's reply is a little opaque. :-)
What is that, a base64-encoded commit or something? Indeed, it is, as running it through "base64 -d" yields:
From: Linus Torvalds Date: Sun, 20 Jul 2008 18:07:28 -0700 (PDT) > This warning also seems to be new: > > net/ipv6/addrconf.c: In function ¡addrconf_add_linklocal¢: > net/ipv6/addrconf.c:2318: warning: unused variable ¡net¢ > > and looking at the code it's apparently because I'm not an optimistic > enough dad. > > But hey, if you had three pre-teenage girls, you might not be all that > optimistic either. So I think that's reasonable. > > Problem seems to have been introduced by 53b7997f ("ipv6 netns: Make > several "global" sysctl variables namespace aware") Let's just expand the thing in the one spot it gets referenced in. Please apply, thanks. ipv6: Fix warning in addrconf code. Reported by Linus. Signed-off-by: David S. Miller diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 580ae50..9f4fcce 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -2315,12 +2315,11 @@ static void init_loopback(struct net_device *dev) static void addrconf_add_linklocal(struct inet6_dev *idev, struct in6_addr *addr) { struct inet6_ifaddr * ifp; - struct net *net = dev_net(idev->dev); u32 addr_flags = IFA_F_PERMANENT; #ifdef CONFIG_IPV6_OPTIMISTIC_DAD if (idev->cnf.optimistic_dad && ---
Program Intellivision and play Space Patrol!
Dads
I hear you . . . as I have two teenage girls and one 22 year old son who is back living at home. It is not necessarily the kids that are always the challenge, but being in unity with the wife takes more energy than working with the kids.
I think I need a rest . . . maybe in 5 or 6 years.
Cheers,
Mark